|
| Author | Message |
|---|
Tshedd31
Level 4 Member

Posts: 666 Registered: 2010-07-09
Age: 20 Location: Manchester
 | Subject: /accept, /deny 2011-03-21, 9:46 pm | |
| I know these haven't been working for a while reave and steve, but was wondering if it's something thats a simple fix or if it's a thing with the forum theme, but I thing they're useful to have so applicants can see at a glance if it's a yay or nay. |
|
 | |
TideSwayer
Administrator

Posts: 3613 Registered: 2009-03-17
 | Subject: Re: /accept, /deny 2011-03-21, 11:36 pm | |
| Besides the fact that it stopped working 100% of the time for some odd reason, it's a better idea in theory than it is in practice. Every time you edited a post (and this has to be done for the formal accept/deny/trials thread marker), it took the new colored 'accept' and 'deny' used in the post(s) and substituted color code in again. (Just the way substitution works, since it's technically the same string as before just surrounded by color tags.) Basically, it makes a mess of the post with 'accept' and 'deny' surrounded by several nested red/green color tags. You won't see it in a normal view of the post (as outer nested color codes take precedence over each preceding inner one), but a glance at the 'Edit Post' box will show the mess they make. All you should do now instead is just color /accept and /deny manually when you write it. It's easy enough to do and saves a hell of a lot of post cleanup hassle. There's a red and a green built-in. If you want to use the bright green, it's color code lime. For /accept, you'd type: | Code: | [color=lime][b]/accept[/b][/color] |
For /deny, you'd type:
| Code: | [color=red][b]/deny[b][/color] |
You'll notice I am also using the b and /b tags too. I always use those BOLD tags whenever I color text. You don't have to, but I think it makes it stand out even more.______________________  |
|
 | |
Reave
Administrator

Posts: 1890 Registered: 2009-03-17
Age: 21 Location: Connecticut
 | Subject: Re: /accept, /deny 2011-03-22, 8:55 am | |
| | Tshedd31 wrote: | | I know these haven't been working for a while reave and steve, but was wondering if it's something thats a simple fix. |
hmm.... just took a look, it all got whipped out. How it worked originally was by word censoring.
It's now fixed and every new post/reply will display it again. Existing posts will still be non censored until a mod/user clicks edit and saves the post which will update it.
EDIT: Removed due to too many issues. ______________________ Web Designer & Developer @ Tinyminute.com / Gamer / Apple Geek / I.T. Guy / MacBook Pro User
Last edited by Reave on 2011-03-22, 9:21 am; edited 2 times in total |
|
 | |
TideSwayer
Administrator

Posts: 3613 Registered: 2009-03-17
 | Subject: Re: /accept, /deny 2011-03-22, 9:10 am | |
| | Reave wrote: | | Tshedd31 wrote: | | I know these haven't been working for a while reave and steve, but was wondering if it's something thats a simple fix. |
hmm.... just took a look, it all got whipped out. How it worked originally was by word censoring.
It's now fixed and every new post/reply will display it again. Existing posts will still be non censored until a mod clicks edit and saves the post which will update it. |
The issue that I mentioned still stands. EVERY TIME you edit a post, since [b]/accept[/b] and [b]/deny[b] are still part of the substitution string, they will get substituted again.
Even something small as three post edits can get a post looking like:
| Code: | [color=lime][b][color=lime][b]/accept[/b][/color][/b][/color]
to
[color=lime][b][color=lime][b][color=lime][b]/accept[/b][/color][/b][/color][/b][/color]
to
[color=lime][b][color=lime][b][color=lime][b][color=lime][b]/accept[/b][/color][/b][/color][/b][/color][/b][/color]
to
[color=lime][b][color=lime][b][color=lime][b][color=lime][b][color=lime][b]/accept[/b][/color][/b][/color][/b][/color][/b][/color][/b][/color]
|
You won't see it in the normal forum post view, but the actual post keeps getting nested with [b]/accept[/b] and [b][b]/deny[b][b] text substitutions. It's recursively substituting since the original string to substitute is also part of the substitution string.
This is why automatic substitutions of the same string text is BAD, oh so bad.______________________  |
|
 | |
TideSwayer
Administrator

Posts: 3613 Registered: 2009-03-17
 | Subject: Re: /accept, /deny 2011-03-22, 9:11 am | |
| Shit. I just had to make edits to that above post and the shit is already happening. Ugh.  The substitution string must be wrong somewhere, Reave, since I shouldn't be seeing any tags in the normal post view. ______________________ 
Last edited by TideSwayer on 2011-03-22, 9:13 am; edited 1 time in total |
|
 | |
Reave
Administrator

Posts: 1890 Registered: 2009-03-17
Age: 21 Location: Connecticut
 | Subject: Re: /accept, /deny 2011-03-22, 9:12 am | |
| I see what your taking about Steve, it keeps replying itself, clutters the post, and annoying when editing. Removed the word censoring. ______________________ Web Designer & Developer @ Tinyminute.com / Gamer / Apple Geek / I.T. Guy / MacBook Pro User
Last edited by Reave on 2011-03-22, 9:19 am; edited 1 time in total |
|
 | |
TideSwayer
Administrator

Posts: 3613 Registered: 2009-03-17
 | Subject: Re: /accept, /deny 2011-03-22, 9:18 am | |
| The closing bold tag on the deny substitution string needs a slash. That's what's wrong with the substitution text. ______________________  |
|
 | |
Reave
Administrator

Posts: 1890 Registered: 2009-03-17
Age: 21 Location: Connecticut
 | Subject: Re: /accept, /deny 2011-03-22, 9:27 am | |
| | TideSwayer wrote: | | The closing bold tag on the deny substitution string needs a slash. That's what's wrong with the substitution text. |
I tried it without the bold tags for word censoring and shows properly, but as you said and what I saw the color tag will reapply itself on adding additional color tag on each edit. ______________________ Web Designer & Developer @ Tinyminute.com / Gamer / Apple Geek / I.T. Guy / MacBook Pro User
Last edited by Reave on 2011-03-22, 9:32 am; edited 4 times in total |
|
 | |
|